Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Use opcua server timestamp in opcua-adapter messages #980

Merged
merged 3 commits into from
Dec 16, 2019
Merged

NOISSUE - Use opcua server timestamp in opcua-adapter messages #980

merged 3 commits into from
Dec 16, 2019

Conversation

manuio
Copy link
Contributor

@manuio manuio commented Dec 14, 2019

No description provided.

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio requested a review from a team as a code owner December 14, 2019 17:56
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #980 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
- Coverage   83.78%   83.74%   -0.04%     
==========================================
  Files          76       76              
  Lines        5327     5327              
==========================================
- Hits         4463     4461       -2     
- Misses        588      590       +2     
  Partials      276      276
Impacted Files Coverage Δ
things/service.go 88.97% <0%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e960004...4912abc. Read the comment docs.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmarcetic nmarcetic merged commit bdeb771 into absmach:master Dec 16, 2019
@manuio manuio deleted the opcua branch December 16, 2019 15:14
manuio added a commit that referenced this pull request Oct 12, 2020
* NOISSUE - Use opcua server timestamp in opcua-adapter messages

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Rename pubsub -> subscribe

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Typo

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants